> -----Original Message----- > From: Richard Henderson <richard.hender...@linaro.org> > Sent: Friday, August 28, 2020 8:03 PM > To: Taylor Simpson <tsimp...@quicinc.com>; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 30/34] Hexagon (target/hexagon) TCG for > instructions with multiple definitions > > On 8/18/20 8:50 AM, Taylor Simpson wrote: > > +++ b/target/hexagon/helper.h > > @@ -15,6 +15,8 @@ > > * along with this program; if not, see <http://www.gnu.org/licenses/>. > > */ > > > > +#include "gen_tcg.h" > > Why would you need this here? Definitely looks wrong.
I'll add the following comment to indicate what's going on /* * Each of the generated helpers is wrapped with #ifndef fGEN_TCG_<tag>. * For example * #ifndef fGEN_TCG_A2_add * DEF_HELPER_3(A2_add, s32, env, s32, s32) * #endif * We include gen_tcg.h here to provide definitions of fGEN_TCG for any instructions that * are overridden. * * This prevents unused helpers from taking up space in the executable. */
