> -----Original Message----- > From: Richard Henderson <richard.hender...@linaro.org> > Sent: Sunday, August 30, 2020 5:33 PM > To: Taylor Simpson <tsimp...@quicinc.com>; qemu-devel@nongnu.org > Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi; > aleksandar.m.m...@gmail.com; a...@rev.ng > Subject: Re: [RFC PATCH v3 00/34] Hexagon patch series > > I don't mind intermediate updates. Just keep a list in the cover letter of > the > things that are still on the to-do list, and I'll not focus on those. > > We could also talk about what portions of the to-do list are blocker, and what > can be done via normal development. Because neither you nor I want to > carry > around this huge patch set forever.
OK, here's the list of items. Let me know if I missed anything. I'll indicate which ones can be done quickly and which ones would take more time. I added a column for blocker if you or anyone else has input on that. PatchItemEffortBlocker Use qemu softfloat??Yes Use qemu decodetree.py?? SeveralUse const when appropriatesmall SeveralRemove anything after g_assert_not_reachedsmall SeveralFix log_store32/64 add/remove/add in patch seriessmall SeveralFollow naming guidelines for structs and enumssmall 04Move decls to cpu-param.hsmall 04Remove CONFIG_USER_ONLY ifdef'ssmall 04Remove DEBUG_HEXAGONsmall 04Remove stack pointer modification hack, use qemu mechanismsmall 04Add property x-lldb-compat to control output in logsmall 06Include instruction and raw bytes in disassemblysmall 07Use DEF_HELPER_FLAGSsmall 07, 26Endianness of merge_bytessmall 07Fix overlap testsmall 07Remove HELPER(debug_value)/HELPER(debug_value_i64)small 09Include "qemu/osdep.h" instead of <stdint.h>small 10 (and others)Stick with stdint.h types except in imported filessmall 11Remove description from reg field definitionssmall 13Move regmap.h into decode.csmall 14, 27Use bit mask instead of strings in decodingsmall 14Add comments to decodersmall 16Use qemu/int128.hmedium 17Squash patches dealing with imported filessmall 24Use qemu/bitops.h for instruction attributessmall 24Fix initialization of opcode_short_semanticssmall 24Change if (p == NULL) { g_assert_not_reached(); } to assert(p != NULL)small 25Expand DECL/READ/WRITE/FREE macros into generated codesmall 26Rewrite fINSERT*, fEXTRACT*, f?XTN macrossmall 26Investigate fRND macrosmall 26Change REG = REG to (VOID)REG to suppress compiler warningsmall 27Remove multiple includes of imported/iclass.defsmall 28Move genptr_helpers.h into genptr.csmall 28Remove unneeded tempssmall 28Use tcg_gen_deposit_tl and tcg_gen_extract_tl when dealing with p3_0small 29Size opcode_genptr[] properly and initialize with [TAG] = generate_##TAGsmall 30Don't generate helpers for instructions that are overriddensmall Don't include "gen_tcg.h" in helper.h 31Use bitmask for ctx->reg_log instead of an arraysmall 31Use tcg_gen_extract_i32 for gen_slot_cancelled_checksmall 31Properly deal with reading instructions across a page boundary and toomedium many instructions before finding end-of-packet 31Don't set PC at the beginning of every packetmedium 31Don't set slot_cancelled unless neededsmall 31Don't set hex_pred_written unless neededmedium 31Change cancelled variable to not localsmall 31Remove unnecessary tempsmall 31Let tcg_gen_addi_tl check for zerosmall 31Move gen_exec_counters to end of TB instead of every packetmedium 31Move end of TB handling to hexagon_tr_tb_stopsmall