On Tue, Sep 01, 2020 at 03:54:29PM +0100, Peter Maydell wrote: > On Tue, 1 Sep 2020 at 15:16, Gerd Hoffmann <kra...@redhat.com> wrote: > > > > Hi, > > > > > Generating ar with a custom command > > > cp: '../../pc-bios/keymaps/ar' and 'pc-bios/keymaps/ar' are the same file > > > > Hmm, strange. No failures in gitlab ci: > > https://gitlab.com/kraxel/qemu/-/pipelines/183769485 > > > > Any chance this is an old build tree? Specifically created before > > commit ddcf607fa3d6 ("meson: drop keymaps symlink") was merged, and the > > symlink is present still? > > Yeah, mostly my build trees don't get regenerated. We like > incremental builds to continue to work.
So just not creating the symlink isn't enough, i.e. configure must remove it if present? Or is requiring fresh build trees ok if announced in the cover letter / pull request? thanks, Gerd
