On Mittwoch, 2. September 2020 15:45:03 CEST Daniel P. Berrangé wrote:
> To be clear, I'm not objecting to warning - just that the proposed warning
> doesn't give any useful information about what is considered to be a
> sensible alternative size, and nor does the commit message.
>
> Just like to see the commit message provide the background info above,
> and ideally have the warning message at least give the user a suggestion
> that is in the sensible order of magnitude they should be looking at.
>
> eg tell them to aim for 1 MB (or whatever value) as a starting point to
> tuning.
Yeah, I know, but the problem is I don't see how I would squeeze the relevant
information into only one log message; and even "what's a good starting point"
is already questionable.
For that reason my plan was:
- logging this warning
- describing the 'msize' issue in detail on the QEMU wiki (what's the
point, how would you benchmark it)
So my idea was: user sees the message, "what is 'msize?'" -> Google "msize
qemu" -> click 'QEMU wiki' -> read all the details.
But how about this: I put a QEMU wiki link directly into the log message?
P.S. I don't have a QEMU wiki account yet BTW, so if somebody could hook me
up, very much appreciated!
Best regards,
Christian Schoenebeck
