Re: [Qemu-devel] [PATCH] memory: synchronize dirty bitmap before unmapping a range

[Anthony Liguori]

On 07/31/2011 02:47 PM, Avi Kivity wrote:

When a range is being unmapped, ask accelerators (e.g. kvm) to synchronize the
dirty bitmap to avoid losing information forever.

Fixes grub2 screen update.

Signed-off-by: Avi Kivity<a...@redhat.com>

Applied.  Thanks.

Regards,

Anthony Liguori

---

Please apply before the PCI batch to avoid bisectability issues (and don't
pull, since that removes ordering).

  memory.c |    4 ++++
  1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/memory.c b/memory.c
index 5c6e63d..5f20320 100644
--- a/memory.c
+++ b/memory.c
@@ -245,6 +245,10 @@ static void as_memory_range_add(AddressSpace *as, 
FlatRange *fr)

  static void as_memory_range_del(AddressSpace *as, FlatRange *fr)
  {
+    if (fr->dirty_log_mask) {
+        cpu_physical_sync_dirty_bitmap(fr->addr.start,
+                                       fr->addr.start + fr->addr.size);
+    }
      cpu_register_physical_memory(fr->addr.start, fr->addr.size,
                                   IO_MEM_UNASSIGNED);
  }