Philippe Mathieu-Daudé <phi...@redhat.com> 于2020年9月5日周六 上午12:26写道: > > pci_dma_rw() returns a MemTxResult type. > Do not discard it, return it to the caller. > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Reviewed-by: Li Qiang <liq...@gmail.com> > --- > include/hw/pci/pci.h | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > index bb57525dffd..76826e240a9 100644 > --- a/include/hw/pci/pci.h > +++ b/include/hw/pci/pci.h > @@ -824,8 +824,20 @@ static inline MemTxResult pci_dma_read(PCIDevice *dev, > dma_addr_t addr, > return pci_dma_rw(dev, addr, buf, len, DMA_DIRECTION_TO_DEVICE); > } > > -static inline int pci_dma_write(PCIDevice *dev, dma_addr_t addr, > - const void *buf, dma_addr_t len) > +/** > + * pci_dma_write: Write to address space from PCI device. > + * > + * Return a MemTxResult indicating whether the operation succeeded > + * or failed (eg unassigned memory, device rejected the transaction, > + * IOMMU fault). > + * > + * @dev: #PCIDevice doing the memory access > + * @addr: address within the #PCIDevice address space > + * @buf: buffer with the data transferred > + * @len: the number of bytes to write > + */ > +static inline MemTxResult pci_dma_write(PCIDevice *dev, dma_addr_t addr, > + const void *buf, dma_addr_t len) > { > return pci_dma_rw(dev, addr, (void *) buf, len, > DMA_DIRECTION_FROM_DEVICE); > } > -- > 2.26.2 > >