On Wed, Sep 09, 2020 at 03:51:14PM +0800, Haibo Xu wrote:
> > > +
> > > + if (spe) {
> > > + assert(ARM_CPU(cpu)->has_spe == ON_OFF_AUTO_ON);
> > > + if (kvm_irqchip_in_kernel()) {
> > > + kvm_arm_spe_set_irq(cpu, PPI(VIRTUAL_SPE_IRQ));
> > > + }
> > > + kvm_arm_spe_init(cpu);
> >
> > A later patch introduces userspace irqchip support. Should we avoid
> > allowing it until then to avoid breaking bisection?
> >
>
> Yes, it's possible to break the bisection. To avoid it I think we can
> move the above codes
> block to a separate patch after adding the userspace irqchip support,
> Or, just put the userspace
> irqchip support patch before this patch. What's your opinion?
>
This patch ca forbid SPE without kernel irqchip. Then the patch that adds
userspace irqchip support would also remove the restriction.
Thanks,
drew
