On Tue, Sep 8, 2020 at 7:52 AM Peter Maydell <peter.mayd...@linaro.org> wrote: > > On Thu, 28 May 2020 at 23:31, Alistair Francis <alistair.fran...@wdc.com> > wrote: > > > > This adds a barebone OpenTitan machine to QEMU. > > > > Signed-off-by: Alistair Francis <alistair.fran...@wdc.com> > > Reviewed-by: Bin Meng <bin.m...@windriver.com> > > --- > > default-configs/riscv32-softmmu.mak | 1 + > > default-configs/riscv64-softmmu.mak | 11 +- > > Just noticed this, but: > > > diff --git a/default-configs/riscv32-softmmu.mak > > b/default-configs/riscv32-softmmu.mak > > index 1ae077ed87..94a236c9c2 100644 > > --- a/default-configs/riscv32-softmmu.mak > > +++ b/default-configs/riscv32-softmmu.mak > > @@ -10,3 +10,4 @@ CONFIG_SPIKE=y > > CONFIG_SIFIVE_E=y > > CONFIG_SIFIVE_U=y > > CONFIG_RISCV_VIRT=y > > +CONFIG_OPENTITAN=y > > diff --git a/default-configs/riscv64-softmmu.mak > > b/default-configs/riscv64-softmmu.mak > > index 235c6f473f..aaf6d735bb 100644 > > --- a/default-configs/riscv64-softmmu.mak > > +++ b/default-configs/riscv64-softmmu.mak > > @@ -1,3 +1,12 @@ > > # Default configuration for riscv64-softmmu > > > > -include riscv32-softmmu.mak > > +# Uncomment the following lines to disable these optional devices: > > +# > > +#CONFIG_PCI_DEVICES=n > > + > > +# Boards: > > +# > > +CONFIG_SPIKE=y > > +CONFIG_SIFIVE_E=y > > +CONFIG_SIFIVE_U=y > > +CONFIG_RISCV_VIRT=y > > ...shouldn't the riscv64-softmmu config have CONFIG_OPENTITAN too? > The usual principle is that the 64-bit executable can run the > 32-bit boards too.
I didn't know that was the general case. I'll send a patch to enable this. Alistair > > thanks > -- PMM
