On 06.09.20 19:53, Paolo Bonzini wrote: > check-block has its own test harness, unlike every other test. If > we capture its output, as is in general nicer to do without V=1, > there will be no sign of progress. So for lack of a better option > just move the invocation of the test back to Makefile rules. > > As a side effect, this will also fix "make check" in --disable-tools > builds, as they were trying to run qemu-iotests without having > made qemu-img before. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > meson.build | 1 - > tests/Makefile.include | 15 ++++++++++++--- > tests/qemu-iotests/meson.build | 4 ---- > 3 files changed, 12 insertions(+), 8 deletions(-)
I’m not entirely sure why (or I would’ve sent a patch myself), but this breaks all iotests using the socket_scm_helper program unless one runs make check-block before (or make tests/qemu-iotests/socket_scm_helper specifically). It seems like the socket_scm_helper is now only built as a dependency of check-block, instead of all the time. That’s a bit of a shame. (The obvious workaround of course is to specifically build the socket_scm_helper, but that doesn’t seem right.) As a reproducer: [delete build directory, or most importantly the socket_scm_helper] [configure] [make] $ cd tests/qemu-iotests $ ./check -nbd 147 [...] +qemu.machine.QEMUMachineError: socket_scm_helper does not exist [...] Max
signature.asc
Description: OpenPGP digital signature