On Mon, Sep 14, 2020 at 10:41 PM Peter Maydell <peter.mayd...@linaro.org> wrote:
> On Sun, 13 Sep 2020 at 19:51, Philippe Mathieu-Daudé <phi...@redhat.com> > wrote: > > > > On 9/13/20 6:01 PM, 罗勇刚(Yonggang Luo) wrote: > > > > > > > > > On Sun, Sep 13, 2020 at 11:35 PM Philippe Mathieu-Daudé > > > <phi...@redhat.com <mailto:phi...@redhat.com>> wrote: > > > > > > On 9/13/20 12:44 AM, Yonggang Luo wrote: > > > > On windows, a difference in line endings causes testsuite > failures > > > > complaining that every single line in files such as > > > > 'tests/qapi-schemadoc-good.texi' is wrong. Fix it by adding -b > to > > > diff. > > > > > > Isn't '--strip-trailing-cr' more adapted? > > > > > > er, I did that before..... > > > > So, yes/no? We can not follow all patches, so better if you > > add a note about your changes, either in the patch description > > if you think it's worthwhile keeping that information in the > > git history, else below the '---' separator, so that information > > is stripped from the patch when applying. > > > > Looking at the archive I see Thomas said this option is not > > POSIX thus not portable. > > > > What about adding this? > > > > "Ideally we would use the '--strip-trailing-cr' option, but not > > being POSIX is a portability problem (i.e. BSDs and Solaris > > based OSes). Instead use the '-b' option which, although doing > > slightly more, produce the expected result on Windows." > > The other important point to note here is that because > texi output is mostly not case-sensitive, we are not > losing important test coverage by not checking for exact > whitespace matches between the known-good output and > the generated output. If we were checking the doc-good.out > text file, -b would be bad because there whitespace is > important and is part of what we need to be checking. > > (Also the texi stuff is going to go away soon I hope :-)) > So continue with -b are accepted? or I just diable it on win32? > > thanks > -- PMM > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo
