Re: [PATCH 02/15] ppc: Add a return value to ppc_set_compat() and ppc_set_compat_all()

[Vladimir Sementsov-Ogievskiy]

14.09.2020 15:34, Greg Kurz wrote:

As recommended in "qapi/error.h", indicate success / failure with a
return value. Since ppc_set_compat() is called from a VMState handler,

What handler do you mean? You don't update any handlers here..

let's make it an int so that it propagates any negative errno returned
by kvmppc_set_compat(). Do the same for ppc_set_compat_all() for
consistency, even if it isn't called in a context where a negative errno
is required on failure.

This will allow to simplify error handling in the callers.

Signed-off-by: Greg Kurz <gr...@kaod.org>

patch is OK:
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>

--
Best regards,
Vladimir