Hi On Wed, Sep 16, 2020 at 11:35 PM Eduardo Habkost <ehabk...@redhat.com> wrote:
> This series replaces INTERFACE_CHECK with OBJECT_CHECK because > both macros are exactly the same. > > The last patch is a new run of the OBJECT_CHECK -> > DECLARE*_CHECKER* converter script that will convert the former > INTERFACE_CHECK-based macros. > > Well, at least having a different macro allows to tweak qom implementation or replace it with something different more easily. I have some wip branch somewhere where I actually made Interface a different beast than Object (it was saving some fields, and avoiding some potentially wrong casts iirc - I didn't bother to upstream that yet). Also I have a different branch where I played with GObject to replace qom. In both cases, your proposal would have, or would make, the work more complicated. Eduardo Habkost (3): > qom: Correct object_class_dynamic_cast_assert() documentation > qom: Replace INTERFACE_CHECK with OBJECT_CHECK > [automated] Use DECLARE_*CHECKER* macros > > include/hw/acpi/acpi_dev_interface.h | 7 +++---- > include/hw/arm/linux-boot-if.h | 6 +++--- > include/hw/fw-path-provider.h | 6 +++--- > include/hw/hotplug.h | 6 +++--- > include/hw/intc/intc.h | 7 +++---- > include/hw/ipmi/ipmi.h | 6 +++--- > include/hw/isa/isa.h | 2 +- > include/hw/mem/memory-device.h | 6 +++--- > include/hw/nmi.h | 6 +++--- > include/hw/ppc/pnv_xscom.h | 4 ++-- > include/hw/ppc/spapr_irq.h | 4 ++-- > include/hw/ppc/xics.h | 4 ++-- > include/hw/ppc/xive.h | 12 ++++++------ > include/hw/rdma/rdma.h | 7 +++---- > include/hw/rtc/m48t59.h | 6 +++--- > include/hw/stream.h | 6 +++--- > include/hw/vmstate-if.h | 6 +++--- > include/qom/object.h | 14 +------------- > include/qom/object_interfaces.h | 7 +++---- > include/sysemu/tpm.h | 6 +++--- > target/arm/idau.h | 6 +++--- > tests/check-qom-interface.c | 6 +++--- > 22 files changed, 62 insertions(+), 78 deletions(-) > > -- > 2.26.2 > > > > -- Marc-André Lureau
