18.09.2020 17:54, Alberto Garcia wrote:
On Thu 17 Sep 2020 09:55:15 PM CEST, Vladimir Sementsov-Ogievskiy wrote:
It's recommended for bool functions with errp to return true on success
and false on failure. Non-standard interfaces don't help to understand
the code. The change is also needed to reduce error propagation.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
+/*
+ * Return true on success, false on failure. Anyway, if header_updated
+ * provided set it appropriately.
*/
I'm not a native speaker but it sounds a bit odd to me. Maybe "If
header_updated is not NULL then it is set appropriately regardless of
the return value".
That's better I think, thanks.
But I'm fine with your version, so
Reviewed-by: Alberto Garcia <be...@igalia.com>
Berto
--
Best regards,
Vladimir
