On Wed, Aug 10, 2011 at 10:10:59AM +0200, Gerd Hoffmann wrote: > Hi, > > >>I think it would also be nice to somehow hint this is the spice > >sent a second patch (fixing the above), but didn't do any hinting. I'll send > >a third. > > Saw v2. I would just stick a "version" string into the dict instead > of the three values for major, minor and micro. >
Argh. Sent v3 with the three ints. Do you prefer a single version? > >>version qemu was compiled against. The shared library which is > >>actually used might be newer. > > > >I thought of this problem but decided it's better to at least have the > >compiled > >version (getting the linked against version is not hard, but I'd rather > >not force to do it at this moment - I guess via dlopen. Which is linux > >specific - > >will need yet another wrapper for that api to compile on windows). > > The compiled version is perfectly fine, I think it is more useful to > have that one as it decides which features qemu is able to use. > Just completeness :) I'm not going to do it right now anyway. > If we want report the runtime version too (any reason to do this?) > I'd just add a spice_server_get_version() function to the library. > > cheers, > Gerd >