On Sep 21 08:20, Keith Busch wrote: > On Fri, Sep 18, 2020 at 10:36:13PM +0200, Klaus Jensen wrote: > > +static inline bool nvme_req_is_write(NvmeRequest *req) > > +{ > > + switch (req->cmd.opcode) { > > + case NVME_CMD_WRITE: > > + case NVME_CMD_WRITE_ZEROES: > > + return true; > > + default: > > + return false; > > + } > > +} > > It doesn't look like this is called for WRITE_ZEROES anywhere. It also > looks like this helper is a bit unnecessary. We can reorganize some of > the flow so that we're not checking the opcode twice: >
Ooops. Yes, that is a leftover from when I had a patch that combined nvme_rw and nvme_write_zeroes in the series. I'll remove it.
signature.asc
Description: PGP signature