On 23/09/2020 18.26, Paolo Bonzini wrote: > On 23/09/20 18:04, Thomas Huth wrote: >> On 23/09/2020 17.10, Paolo Bonzini wrote: >>> The TCI test is already performed on gitlab CI, and it fails because >>> Travis tests (generally) disable tools and therefore do not have >>> "make check-qtest". Just remove it. >> Huh? Where is it failing? It currently seems to work fine: >> >> https://travis-ci.org/github/qemu/qemu/jobs/729440748 >> >> Anyway, since we already have similar job in the Gitlab-CI, I think it's >> ok to remove it from Travis, so with the commit message tweaked: >> >> Acked-by: Thomas Huth <th...@redhat.com> >> >> > > You're right, it's only broken on my own branch (due to "meson: qtest: > set "depends" correctly"). Currently we're running all qtests with a > QTEST_QEMU_IMG pointing to a nonexistent executable, and I'd rather > avoid that. In that patch I took the big hammer, but we can also decide > not to remove qtests for --disable-tools and add a little bit of > complication to tests/qtest/meson.build.
I think there are only very few qtests that need one of the tools, so I'd prefer if we could keep at least the ones enabled with --disable-tools that do not require any of the tools. Thomas