Patchew URL: https://patchew.org/QEMU/20200923161031.69474-1-stefa...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200923161031.69474-1-stefa...@redhat.com Subject: [PULL 00/13] Block patches === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20200923161031.69474-1-stefa...@redhat.com -> patchew/20200923161031.69474-1-stefa...@redhat.com Switched to a new branch 'test' 4bf3742 qemu/atomic.h: rename atomic_ to qatomic_ 8cecbb3 tests: add test-fdmon-epoll 8df4df8 fdmon-poll: reset npfd when upgrading to fdmon-epoll 825386c gitmodules: add qemu.org vbootrom submodule 5cae6f8 gitmodules: switch to qemu.org meson mirror 98349d3 gitmodules: switch to qemu.org qboot mirror 5f9d298 docs/system: clarify deprecation schedule b431c3a virtio-crypto: don't modify elem->in/out_sg c1f9691 virtio-blk: undo destructive iov_discard_*() operations 4182d4f util/iov: add iov_discard_undo() a59a839 virtio: add vhost-user-fs-ccw device 0d23a8c libvhost-user: handle endianness as mandated by the spec 3167d81 MAINTAINERS: add Stefan Hajnoczi as block/nvme.c maintainer === OUTPUT BEGIN === 1/13 Checking commit 3167d818e62a (MAINTAINERS: add Stefan Hajnoczi as block/nvme.c maintainer) 2/13 Checking commit 0d23a8ccd2a9 (libvhost-user: handle endianness as mandated by the spec) WARNING: line over 80 characters #53: FILE: contrib/libvhost-user/libvhost-user.c:548: + vu_panic(dev, "virtio legacy devices aren't supported by libvhost-user"); total: 0 errors, 1 warnings, 217 lines checked Patch 2/13 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/13 Checking commit a59a839e1d76 (virtio: add vhost-user-fs-ccw device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 82 lines checked Patch 3/13 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/13 Checking commit 4182d4f76678 (util/iov: add iov_discard_undo()) 5/13 Checking commit c1f96917a3f1 (virtio-blk: undo destructive iov_discard_*() operations) 6/13 Checking commit b431c3a4b415 (virtio-crypto: don't modify elem->in/out_sg) 7/13 Checking commit 5f9d298c71ad (docs/system: clarify deprecation schedule) 8/13 Checking commit 98349d316498 (gitmodules: switch to qemu.org qboot mirror) 9/13 Checking commit 5cae6f86bb22 (gitmodules: switch to qemu.org meson mirror) 10/13 Checking commit 825386c4f0f2 (gitmodules: add qemu.org vbootrom submodule) 11/13 Checking commit 8df4df890bf1 (fdmon-poll: reset npfd when upgrading to fdmon-epoll) 12/13 Checking commit 8cecbb39509f (tests: add test-fdmon-epoll) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 total: 0 errors, 1 warnings, 89 lines checked Patch 12/13 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/13 Checking commit 4bf37426ff03 (qemu/atomic.h: rename atomic_ to qatomic_) ERROR: Macros with multiple statements should be enclosed in a do - while loop #2800: FILE: include/qemu/atomic.h:152: +#define qatomic_rcu_read__nocheck(ptr, valptr) \ + __atomic_load(ptr, valptr, __ATOMIC_RELAXED); \ smp_read_barrier_depends(); ERROR: space required before that '*' (ctx:VxB) #2945: FILE: include/qemu/atomic.h:333: +#define qatomic_read__nocheck(p) (*(__typeof__(*(p)) volatile*) (p)) ^ ERROR: Use of volatile is usually wrong, please add a comment #2945: FILE: include/qemu/atomic.h:333: +#define qatomic_read__nocheck(p) (*(__typeof__(*(p)) volatile*) (p)) ERROR: space required before that '*' (ctx:VxB) #2946: FILE: include/qemu/atomic.h:334: +#define qatomic_set__nocheck(p, i) ((*(__typeof__(*(p)) volatile*) (p)) = (i)) ^ ERROR: Use of volatile is usually wrong, please add a comment #2946: FILE: include/qemu/atomic.h:334: +#define qatomic_set__nocheck(p, i) ((*(__typeof__(*(p)) volatile*) (p)) = (i)) ERROR: space required after that ',' (ctx:VxV) #2951: FILE: include/qemu/atomic.h:337: +#define qatomic_set(ptr, i) qatomic_set__nocheck(ptr,i) ^ ERROR: memory barrier without comment #3023: FILE: include/qemu/atomic.h:395: +#define qatomic_xchg(ptr, i) (smp_mb(), __sync_lock_test_and_set(ptr, i)) WARNING: Block comments use a leading /* on a separate line #3097: FILE: include/qemu/atomic.h:447: +/* qatomic_mb_read/set semantics map Java volatile variables. They are WARNING: Block comments use a leading /* on a separate line #6180: FILE: util/bitmap.c:214: + /* If we avoided the full barrier in qatomic_or(), issue a WARNING: Block comments use a leading /* on a separate line #7195: FILE: util/rcu.c:85: + /* Instead of using qatomic_mb_set for index->waiting, and WARNING: Block comments use a leading /* on a separate line #7221: FILE: util/rcu.c:154: + /* In either case, the qatomic_mb_set below blocks stores that free total: 7 errors, 4 warnings, 6267 lines checked Patch 13/13 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200923161031.69474-1-stefa...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com