will be also nice to squash the following on top for a complete clean checkpatch version, as the original patch introduces at least 1 issue
Carlo --- >8 --- Subject: fixup! [PATCH 1/2] qemu/atomic.h: rename atomic_ to qatomic_ fixes: ERROR: Macros with multiple statements should be enclosed in a do - while loop +#define qatomic_rcu_read__nocheck(ptr, valptr) \ + __atomic_load(ptr, valptr, __ATOMIC_RELAXED); \ smp_read_barrier_depends(); false positive: ERROR: memory barrier without comment +#define qatomic_xchg(ptr, i) (smp_mb(), __sync_lock_test_and_set(ptr, i)) Signed-off-by: Carlo Marcelo Arenas Belón <care...@gmail.com> --- include/qemu/atomic.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h index 87b85f9f6d..be47e083be 100644 --- a/include/qemu/atomic.h +++ b/include/qemu/atomic.h @@ -149,9 +149,10 @@ #define qatomic_rcu_read__nocheck(ptr, valptr) \ __atomic_load(ptr, valptr, __ATOMIC_CONSUME); #else -#define qatomic_rcu_read__nocheck(ptr, valptr) \ +#define qatomic_rcu_read__nocheck(ptr, valptr) do { \ __atomic_load(ptr, valptr, __ATOMIC_RELAXED); \ - smp_read_barrier_depends(); + smp_read_barrier_depends(); \ +} while (0) #endif #define qatomic_rcu_read(ptr) \ -- 2.28.0.681.g6f77f65b4e