On Wed, Sep 23, 2020 at 07:08:50PM -0400, Cleber Rosa wrote: > On Tue, Sep 22, 2020 at 05:00:47PM -0400, John Snow wrote: > > The edge case is that if the name is '', this expression returns a > > string instead of a bool, which violates our declared type. > > > > Signed-off-by: John Snow <js...@redhat.com> > > --- > > scripts/qapi/gen.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py > > index 9898d513ae..cb2b2655c3 100644 > > --- a/scripts/qapi/gen.py > > +++ b/scripts/qapi/gen.py > > @@ -251,7 +251,7 @@ def __init__(self, prefix, what, user_blurb, > > builtin_blurb, pydoc): > > > > @staticmethod > > def _is_user_module(name): > > - return name and not name.startswith('./') > > + return name is not None and not name.startswith('./') > > Another possibility here that handles the empty string situation and > will never return anything but a bool: > > return all([name, not name.startswith('./')]) >
Never mind me... I noticed that this actually gets called with None. - Cleber.
signature.asc
Description: PGP signature