On 08/11/2011 09:38 AM, Blue Swirl wrote: > On Thu, Aug 11, 2011 at 12:58 PM, Avi Kivity <a...@redhat.com> wrote: >> On 08/11/2011 03:36 PM, Alexander Graf wrote: >>> >>>> >>>> Or to have automatic generation of the optionals based on the >>>> primitives, if the optionals are not present. >>> >>> That's what's happening in the background already, no? The line is towards >>> tcg users though, not it tcg internal code. >>> >> >> Yes, and it doesn't make sense to optimize through synthetic instructions. > > I'd just create all INDEX_op_* enums and adjust TCG targets etc. to > call tcg_abort() in the default case. >
Seconded. We can still expand the optional enums exactly as we do now, but make sure that the enum is always present. That'll clean up a *lot* of ifdefs throughout tcg/*. r~
