On Jul 29 15:01, Andrzej Jakowski wrote: > Resending series recently posted on mailing list related to nvme device > extension with couple of fixes after review. > > This patch series does following: > - Fixes problem where CMBS bit was not set in controller capabilities > register, so support for CMB was not correctly advertised to guest. > This is resend of patch that has been submitted and reviewed by > Klaus [1] > - Introduces BAR4 sharing between MSI-X vectors and CMB. This allows > to have CMB and PMR emulated on the same device. This extension > was indicated by Keith [2] > > v6: > - instead of using memory_region_to_absolute_addr() function local helper has > been defined (nvme_cmb_to_absolute_addr()) to calculate absolute address of > CMB in simplified way. Also a number of code style changes has been done > (function rename, use literal instead of macro definition, etc.) > > v5: > - fixed problem introduced in v4 where CMB buffer was represented as > subregion of BAR4 memory region. In that case CMB address was used > incorrectly as it was relative to BAR4 and not absolute. Appropriate > changes were added to v5 to calculate CMB address properly ([6]) > > v4: > - modified BAR4 initialization, so now it consists of CMB, MSIX and > PBA memory regions overlapping on top of it. This reduces patch > complexity significantly (Klaus [5]) > > v3: > - code style fixes including: removal of spurious line break, moving > define into define section and code alignment (Klaus [4]) > - removed unintended code reintroduction (Klaus [4]) > > v2: > - rebase on Kevin's latest block branch (Klaus [3]) > - improved comments section (Klaus [3]) > - simplified calculation of BAR4 size (Klaus [3]) > > v1: > - initial push of the patch > > [1]: > https://lore.kernel.org/qemu-devel/20200408055607.g2ii7gwqbnv6cd3w@apples.localdomain/ > [2]: > https://lore.kernel.org/qemu-devel/20200330165518.ga8...@redsun51.ssa.fujisawa.hgst.com/ > [3]: > https://lore.kernel.org/qemu-devel/20200605181043.28782-1-andrzej.jakow...@linux.intel.com/ > [4]: > https://lore.kernel.org/qemu-devel/20200618092524.posxi5mysb3jjtpn@apples.localdomain/ > [5]: > https://lore.kernel.org/qemu-devel/20200626055033.6vxqvi4s5pll7som@apples.localdomain/ > [6]: > https://lore.kernel.org/qemu-devel/9143a543-d32d-f3e7-c37b-b3df7f853...@linux.intel.com/ >
Hi Andrzej, Any chance you can respin this on git.infradead.org/qemu-nvme.git nvme-next branch? Thanks, Klaus
signature.asc
Description: PGP signature