> -----Original Message----- > From: Philippe Mathieu-Daudé <philippe.mathieu.da...@gmail.com> On > Behalf Of Philippe Mathieu-Daudé > Sent: Tuesday, September 29, 2020 6:22 AM > To: Taylor Simpson <tsimp...@quicinc.com>; qemu-devel@nongnu.org > Cc: a...@rev.ng; riku.voi...@iki.fi; richard.hender...@linaro.org; > laur...@vivier.eu; aleksandar.m.m...@gmail.com > Subject: Re: [RFC PATCH v4 00/29] Hexagon patch series > > cc1: all warnings being treated as errors > make: *** [Makefile.ninja:638: > libqemu-hexagon-linux-user.fa.p/target_hexagon_decode.c.o] Error 1 > > $ gcc --version > gcc (GCC) 10.2.1 20200723 (Red Hat 10.2.1-1) >
Thanks for all your feedback. I really appreciate it and will make the changes you mentioned. I'm using an older GCC that doesn't have these errors. Is this the version of GCC that is recommended (mandated?) for building qemu? PS You were right about Richard recommending const. It's already on my TODO list from his review 😉 Thanks, Taylor
