Yonggang Luo <luoyongg...@gmail.com> writes:
> This is used for counting how much function are export to qemu plugin.
>
> Signed-off-by: Yonggang Luo <luoyongg...@gmail.com>
> ---
> plugins/api.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/plugins/api.c b/plugins/api.c
> index f16922ca8b..d325084385 100644
> --- a/plugins/api.c
> +++ b/plugins/api.c
> @@ -252,10 +252,12 @@ bool qemu_plugin_mem_is_store(qemu_plugin_meminfo_t
> info)
>
> #ifdef CONFIG_SOFTMMU
> static __thread struct qemu_plugin_hwaddr hwaddr_info;
> +#endif
>
> struct qemu_plugin_hwaddr *qemu_plugin_get_hwaddr(qemu_plugin_meminfo_t info,
> uint64_t vaddr)
> {
> +#ifdef CONFIG_SOFTMMU
> CPUState *cpu = current_cpu;
> unsigned int mmu_idx = info >> TRACE_MEM_MMU_SHIFT;
> hwaddr_info.is_store = info & TRACE_MEM_ST;
> @@ -267,14 +269,10 @@ struct qemu_plugin_hwaddr
> *qemu_plugin_get_hwaddr(qemu_plugin_meminfo_t info,
> }
>
> return &hwaddr_info;
> -}
> #else
> -struct qemu_plugin_hwaddr *qemu_plugin_get_hwaddr(qemu_plugin_meminfo_t info,
> - uint64_t vaddr)
> -{
> return NULL;
> -}
> #endif
> +}
Hmm I'm not sure about this, surely you want the plugin system to
complain early if your plugin is going to use a function that is
incorrect for the mode you are running in?
Although we do currently unconditionally export the syscall functions
and arguably they should be CONFIG_USER only as well.
>
> bool qemu_plugin_hwaddr_is_io(const struct qemu_plugin_hwaddr *haddr)
> {
--
Alex Bennée
