On 10/5/20 9:51 PM, John Snow wrote: > Wildcard includes become hard to manage when refactoring and dealing > with circular dependencies with strictly typed mypy. > > flake8 also flags each one as a warning, as it is not smart enough to > know which names exist in the imported file. > > Remove them and include things explicitly by name instead. > > Signed-off-by: John Snow <js...@redhat.com> > Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> > Reviewed-by: Cleber Rosa <cr...@redhat.com> > --- > scripts/qapi/commands.py | 2 +- > scripts/qapi/events.py | 7 ++++++- > scripts/qapi/gen.py | 12 +++++++++--- > scripts/qapi/introspect.py | 7 ++++++- > scripts/qapi/types.py | 8 +++++++- > scripts/qapi/visit.py | 10 +++++++++- > 6 files changed, 38 insertions(+), 8 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>