Markus Armbruster <arm...@redhat.com> writes: > John Snow <js...@redhat.com> writes: > >> Annotations do not change runtime behavior. >> This commit *only* adds annotations. >> >> Signed-off-by: John Snow <js...@redhat.com> >> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> >> Reviewed-by: Cleber Rosa <cr...@redhat.com> >> --- >> scripts/qapi/events.py | 46 ++++++++++++++++++++++++++++++++---------- >> scripts/qapi/mypy.ini | 5 ----- >> 2 files changed, 35 insertions(+), 16 deletions(-) >> >> diff --git a/scripts/qapi/events.py b/scripts/qapi/events.py >> index f840a62ed92..57e0939e963 100644 >> --- a/scripts/qapi/events.py >> +++ b/scripts/qapi/events.py >> @@ -12,19 +12,31 @@ [...] >> @@ -137,15 +153,15 @@ def gen_event_send(name, arg_type, boxed, >> event_enum_name, event_emit): >> >> class QAPISchemaGenEventVisitor(QAPISchemaModularCVisitor): >> >> - def __init__(self, prefix): >> + def __init__(self, prefix: str): >> super().__init__( >> prefix, 'qapi-events', >> ' * Schema-defined QAPI/QMP events', None, __doc__) >> self._event_enum_name = c_name(prefix + 'QAPIEvent', protect=False) >> - self._event_enum_members = [] >> + self._event_enum_members: List[QAPISchemaEnumMember] = [] >> self._event_emit_name = c_name(prefix + 'qapi_event_emit') >> >> - def _begin_user_module(self, name): >> + def _begin_user_module(self, name: str) -> None: >> events = self._module_basename('qapi-events', name) >> types = self._module_basename('qapi-types', name) >> visit = self._module_basename('qapi-visit', name) >> @@ -168,7 +184,7 @@ def _begin_user_module(self, name): >> ''', >> types=types)) >> >> - def visit_end(self): >> + def visit_end(self) -> None: > > Ignorant question: what's the difference between -> None (like here) and > nothing (like __init__() above?
Looks like commit message of PATCH 24 has an answer. Copy to all the commits that omit -> None similarly? >> self._add_system_module('emit', ' * QAPI Events emission') >> self._genc.preamble_add(mcgen(''' >> #include "qemu/osdep.h" > [...]