John Snow <js...@redhat.com> writes:
> The edge case is that if the name is '', this expression returns a
> string instead of a bool, which violates our declared type.
The edge case is impossible, as discussed in review of v2. I figure the
type checker can't see that, so we need to help it some. Can we mention
this in the commit message?
>
> Signed-off-by: John Snow <js...@redhat.com>
> Reviewed-by: Cleber Rosa <cr...@redhat.com>
> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com>
> ---
> scripts/qapi/gen.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py
> index f2e2746fea5..1bad37fc06b 100644
> --- a/scripts/qapi/gen.py
> +++ b/scripts/qapi/gen.py
> @@ -243,7 +243,7 @@ def __init__(self, prefix, what, user_blurb,
> builtin_blurb, pydoc):
>
> @staticmethod
> def _is_user_module(name):
> - return name and not name.startswith('./')
> + return bool(name and not name.startswith('./'))
return not (name is None or name.startswith('./')
Looks slightly clearer to me.
>
> @staticmethod
> def _is_builtin_module(name):
