On Fri, Oct 02, 2020 at 07:20:48AM +0200, Markus Armbruster wrote: > Stefan Hajnoczi <stefa...@redhat.com> writes: > > On Wed, Sep 30, 2020 at 04:33:18PM +0200, Markus Armbruster wrote: > >> Stefan Hajnoczi <stefa...@redhat.com> writes: > >> > On Wed, Sep 30, 2020 at 07:28:58AM +0200, Markus Armbruster wrote: > >> >> Stefan Hajnoczi <stefa...@redhat.com> writes: > >> Hence my question: is it possible that address families other than unix > >> become available here? > >> > >> When that happens, we have an introspection problem of the sort we > >> common solve with a feature flag. > >> > >> > Accepting any SocketAddr seems reasonable to me since vhost-user > >> > requires an address family that has file descriptor passing. Very few > >> > address families support this feature and we don't expect to add new > >> > ones often. > >> > >> Your answer appears to be "yes in theory, quite unlikely in practice". > >> Correct? > > Keeping introspection "tight" would be nice, but since a real need for > "tight" here seems quite unlikely, it doesn't seem to be worth the > trouble. > > Perhaps this argument could be worked into the commit message. Up to > you. > > Acked-by: Markus Armbruster <arm...@redhat.com>
Thanks, I will update the commit message when merging.
signature.asc
Description: PGP signature
