On 12/10/2020 07.30, David Gibson wrote: > On Sat, Oct 10, 2020 at 08:53:00AM -0700, Elena Afanasova wrote: >> On Sat, 2020-10-10 at 17:07 +1100, David Gibson wrote: >>> On Fri, Oct 09, 2020 at 07:02:56AM -0700, Elena Afanasova wrote: >>>>> From 09905773a00e417d3a37c12350d9e55466fdce8a Mon Sep 17 00:00:00 >>>>> 2001 >>>> From: Elena Afanasova <eafanas...@gmail.com> >>>> Date: Fri, 9 Oct 2020 06:41:36 -0700 >>>> Subject: [PATCH] hw/net: move allocation to the heap due to very >>>> large stack >>>> frame >>> >>> Patch looks fine, but some more details of the motivation would be >>> nice. I wouldn't have thought that the size of a network packet >>> counted as a "very large" stack frame by userspace standards. >>> >> >> gcc with wstack-usage warns that stack frame size may be ~65Kbytes > > AFAICT, -Wstack-usage takes a parameter giving what size it will > complain about. What was that value, and what was the rationale for > choosing it?
I think this is one of the tasks from: https://wiki.qemu.org/Contribute/BiteSizedTasks#Compiler-driven_cleanups It has been added by Paolo in 2016: https://wiki.qemu.org/index.php?title=Contribute/BiteSizedTasks&diff=5368&oldid=5367 ... so maybe Paolo can comment on the size that has been chosen here...? Thomas