Patchew URL: https://patchew.org/QEMU/1602831120-3377-1-git-send-email-che...@lemote.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1602831120-3377-1-git-send-email-che...@lemote.com Subject: [PATCH V14 0/8] mips: Add Loongson-3 machine support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1602831120-3377-1-git-send-email-che...@lemote.com -> patchew/1602831120-3377-1-git-send-email-che...@lemote.com Switched to a new branch 'test' d292df4 docs/system: Update MIPS machine documentation 4e63ead hw/mips: Add Loongson-3 machine support 1bf0737 hw/mips: Add Loongson-3 boot parameter helpers bd43b2f hw/mips: Implement fw_cfg_arch_key_name() f93634a target/mips: Add loongson-ext lsdc2 group of instructions b55eee0 target/mips: Add loongson-ext lswc2 group of instructions (Part 2) 2c2eaaa target/mips: Add loongson-ext lswc2 group of instructions (Part 1) ab68efd target/mips: Fix PageMask with variable page size === OUTPUT BEGIN === 1/8 Checking commit ab68efdc70ef (target/mips: Fix PageMask with variable page size) 2/8 Checking commit 2c2eaaabbd3a (target/mips: Add loongson-ext lswc2 group of instructions (Part 1)) 3/8 Checking commit b55eee07bfbe (target/mips: Add loongson-ext lswc2 group of instructions (Part 2)) 4/8 Checking commit f93634a586de (target/mips: Add loongson-ext lsdc2 group of instructions) 5/8 Checking commit bd43b2ff95e9 (hw/mips: Implement fw_cfg_arch_key_name()) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 60 lines checked Patch 5/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/8 Checking commit 1bf0737aee8c (hw/mips: Add Loongson-3 boot parameter helpers) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 WARNING: line over 80 characters #47: FILE: hw/mips/loongson3_bootp.c:28: +static struct efi_cpuinfo_loongson *init_cpu_info(void *g_cpuinfo, uint64_t cpu_freq) WARNING: line over 80 characters #66: FILE: hw/mips/loongson3_bootp.c:47: +static struct efi_memory_map_loongson *init_memory_map(void *g_map, uint64_t ram_size) total: 0 errors, 3 warnings, 394 lines checked Patch 6/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/8 Checking commit 4e63ead64501 (hw/mips: Add Loongson-3 machine support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #80: new file mode 100644 ERROR: line over 90 characters #151: FILE: hw/mips/loongson3_virt.c:67: + * 3, http://www.anheng.com.cn/loongson/firmware-nonfree/uefi/loongson3-virt/bios_loongson3.bin ERROR: line over 90 characters #152: FILE: hw/mips/loongson3_virt.c:68: + * 4, http://mirrors.ustc.edu.cn/loongson/firmware-nonfree/uefi/loongson3-virt/bios_loongson3.bin ERROR: line over 90 characters #153: FILE: hw/mips/loongson3_virt.c:69: + * 5, http://mirrors.nju.edu.cn/loongson/firmware-nonfree/uefi/loongson3-virt/bios_loongson3.bin ERROR: line over 90 characters #154: FILE: hw/mips/loongson3_virt.c:70: + * 6, https://mirrors.tuna.tsinghua.edu.cn/loongson/firmware-nonfree/uefi/loongson3-virt/bios_loongson3.bin ERROR: line over 90 characters #155: FILE: hw/mips/loongson3_virt.c:71: + * 7, https://mirrors.bfsu.edu.cn/loongson/firmware-nonfree/uefi/loongson3-virt/bios_loongson3.bin ERROR: line over 90 characters #156: FILE: hw/mips/loongson3_virt.c:72: + * 8, https://mirrors.cloud.tencent.com/loongson/firmware-nonfree/uefi/loongson3-virt/bios_loongson3.bin WARNING: line over 80 characters #204: FILE: hw/mips/loongson3_virt.c:120: +static void loongson3_pm_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) WARNING: line over 80 characters #279: FILE: hw/mips/loongson3_virt.c:195: + loaderparams.a2 = cpu_mips_phys_to_kseg0(NULL, loader_rommap[LOADER_PARAM].base); WARNING: line over 80 characters #361: FILE: hw/mips/loongson3_virt.c:277: + fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS, (uint16_t)current_machine->smp.max_cpus); WARNING: line over 80 characters #409: FILE: hw/mips/loongson3_virt.c:325: + sprintf(highmemenv, "%ld", (unsigned long)(loaderparams.ram_size / MiB) - 256); WARNING: line over 80 characters #495: FILE: hw/mips/loongson3_virt.c:411: +static inline void loongson3_virt_devices_init(MachineState *machine, DeviceState *pic) WARNING: line over 80 characters #526: FILE: hw/mips/loongson3_virt.c:442: + get_system_io(), 0, virt_memmap[VIRT_PCIE_PIO].size); WARNING: line over 80 characters #640: FILE: hw/mips/loongson3_virt.c:556: + /* Allocate RAM/BIOS, 0x00000000~0x10000000 is alias of 0x80000000~0x90000000 */ total: 6 errors, 8 warnings, 660 lines checked Patch 7/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/8 Checking commit d292df465eb8 (docs/system: Update MIPS machine documentation) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1602831120-3377-1-git-send-email-che...@lemote.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com