Patchew URL: https://patchew.org/QEMU/20201019051953.90107-...@getutm.app/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201019051953.90107-...@getutm.app Subject: [PATCH RESEND v2 0/9] iOS and Apple Silicon host support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20201019051953.90107-...@getutm.app -> patchew/20201019051953.90107-...@getutm.app Switched to a new branch 'test' 9faec40 block: check availablity for preadv/pwritev on mac 86ad651 tcg: support JIT on Apple Silicon 29dfbc5 tcg: mirror mapping RWX pages for iOS optional b114cca tcg: implement mirror mapped JIT for iOS 88d6dc4 tcg: add const hints for code pointers dd2e464 coroutine: add libucontext as external library 49f3648 qemu: add support for iOS host 90e8d82 configure: cross-compiling without cross_prefix 01c26cd configure: option to disable host block devices === OUTPUT BEGIN === 1/9 Checking commit 01c26cd84fe6 (configure: option to disable host block devices) WARNING: architecture specific defines should be avoided #22: FILE: block/file-posix.c:44: +#if defined(CONFIG_HOST_BLOCK_DEVICE) && defined(__APPLE__) && (__MACH__) total: 0 errors, 1 warnings, 61 lines checked Patch 1/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/9 Checking commit 90e8d8255c14 (configure: cross-compiling without cross_prefix) 3/9 Checking commit 49f3648f7dad (qemu: add support for iOS host) WARNING: architecture specific defines should be avoided #27: FILE: block.c:56: +#if !defined(__DragonFly__) && !defined(CONFIG_IOS) ERROR: braces {} are necessary for all arms of this statement #45: FILE: block/file-posix.c:189: + if (s->fd >= 0) [...] WARNING: architecture specific defines should be avoided #79: FILE: block/file-posix.c:2325: +#if !defined(CONFIG_IOS) && defined(__APPLE__) && defined(__MACH__) WARNING: architecture specific defines should be avoided #363: FILE: tcg/aarch64/tcg-target.h:151: +#if defined(__APPLE__) WARNING: architecture specific defines should be avoided #369: FILE: tcg/aarch64/tcg-target.h:157: +#if defined(__APPLE__) total: 1 errors, 4 warnings, 316 lines checked Patch 3/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/9 Checking commit dd2e4646744e (coroutine: add libucontext as external library) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #97: new file mode 160000 total: 0 errors, 1 warnings, 140 lines checked Patch 4/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/9 Checking commit 88d6dc4d22eb (tcg: add const hints for code pointers) 6/9 Checking commit b114cca7a292 (tcg: implement mirror mapped JIT for iOS) ERROR: externs should be avoided in .c files #51: FILE: accel/tcg/translate-all.c:65: +extern kern_return_t mach_vm_remap(vm_map_t target_task, WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #187: new file mode 100644 WARNING: architecture specific defines should be avoided #416: FILE: tcg/aarch64/tcg-target.h:171: +#if defined(__APPLE__) WARNING: architecture specific defines should be avoided #608: FILE: tcg/i386/tcg-target.h:209: +#ifdef __APPLE__ WARNING: architecture specific defines should be avoided #619: FILE: tcg/i386/tcg-target.h:220: +#if defined(__APPLE__) total: 1 errors, 4 warnings, 1285 lines checked Patch 6/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/9 Checking commit 29dfbc56da64 (tcg: mirror mapping RWX pages for iOS optional) 8/9 Checking commit 86ad651f4ca1 (tcg: support JIT on Apple Silicon) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #206: new file mode 100644 WARNING: architecture specific defines should be avoided #238: FILE: include/tcg/tcg-apple-jit.h:28: +#if defined(__aarch64__) && defined(CONFIG_DARWIN) total: 0 errors, 2 warnings, 259 lines checked Patch 8/9 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/9 Checking commit 9faec405cec8 (block: check availablity for preadv/pwritev on mac) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201019051953.90107-...@getutm.app/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
