Re: [PATCH v7 03/11] hw/block/nvme: Add support for Namespace Types

[Keith Busch]

On Mon, Oct 19, 2020 at 11:17:18AM +0900, Dmitry Fomichev wrote:
> +    QEMU_BUILD_BUG_ON(sizeof(NvmeIdNsDescr) != 4);
...
>      QEMU_BUILD_BUG_ON(sizeof(NvmeIdNsDescr) != 4);

You've got duplicate sizeof checks for the NvmeIdNsDescr.

Otherwise, the patch looks fine.