On 10/20/20 10:11 AM, P J P wrote:
From: Prasad J Pandit <p...@fedoraproject.org>
eth_get_gso_type() routine returns segmentation offload type to use
based on L3 protocol type. It calls g_assert_not_reached if L3
protocol is unknown, making the following return statement unreachable.
Remove the g_assert call, as it maybe triggered by a guest user.
Reported-by: Gaoning Pan <p...@zju.edu.cn>
Signed-off-by: Prasad J Pandit <p...@fedoraproject.org>
---
net/eth.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/eth.c b/net/eth.c
index 0c1d413ee2..f36a418077 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -72,9 +72,6 @@ eth_get_gso_type(uint16_t l3_proto, uint8_t *l3_hdr, uint8_t
l4proto)
}
}
- /* Unsupported offload */
- g_assert_not_reached();
Maybe LOG_UNIMP with useful fields, so when user send bug
report we directly know what has to be implemented.
-
return VIRTIO_NET_HDR_GSO_NONE | ecn_state;
}
