On Thu, Oct 22, 2020 at 09:33:13AM +0200, Klaus Jensen wrote: > + if (--(*discards)) { > + status = NVME_NO_COMPLETE; > + } else { > + g_free(discards); > + req->opaque = NULL;
This case needs a status = req->status; So that we get the error set in the callback. Otherwise, this looks fine. I am assuming everything still runs single threaded since this isn't using atomics.