On Fri, 23 Oct 2020 03:48:39 -0700 <no-re...@patchew.org> wrote: > Patchew URL: > https://patchew.org/QEMU/160344969243.4091343.14371338409686732879.st...@bahia.lan/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 160344969243.4091343.14371338409686732879.st...@bahia.lan > Subject: [PATCH] block: End quiescent sections when a BDS is deleted > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] > patchew/160344969243.4091343.14371338409686732879.st...@bahia.lan -> > patchew/160344969243.4091343.14371338409686732879.st...@bahia.lan > - [tag update] patchew/20201023101222.250147-1-kw...@redhat.com -> > patchew/20201023101222.250147-1-kw...@redhat.com > Switched to a new branch 'test' > f9501f8 block: End quiescent sections when a BDS is deleted > > === OUTPUT BEGIN === > ERROR: Use g_assert or g_assert_not_reached > #73: FILE: block/io.c:640: > + g_assert_cmpint(bs->quiesce_counter, >, 0); >
Ah... sorry I wasn't aware of the story behind glib commit a6a875068779, I'll post a v2 what uses g_assert() instead. > ERROR: Use g_assert or g_assert_not_reached > #74: FILE: block/io.c:641: > + g_assert_cmpint(bs->refcnt, ==, 0); > > total: 2 errors, 0 warnings, 53 lines checked > > Commit f9501f846de1 (block: End quiescent sections when a BDS is deleted) has > style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > === OUTPUT END === > > Test command exited with code: 1 > > > The full log is available at > http://patchew.org/logs/160344969243.4091343.14371338409686732879.st...@bahia.lan/testing.checkpatch/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-de...@redhat.com