On 10/26/2020 6:30 PM, Alex Williamson wrote:
On Mon, 26 Oct 2020 15:06:15 +0530
Kirti Wankhede <kwankh...@nvidia.com> wrote:

VM state change handler is called on change in VM's state. Based on
VM state, VFIO device state should be changed.
Added read/write helper functions for migration region.
Added function to set device_state.

Signed-off-by: Kirti Wankhede <kwankh...@nvidia.com>
Reviewed-by: Neo Jia <c...@nvidia.com>
Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
Reviewed-by: Cornelia Huck <coh...@redhat.com>
---
  hw/vfio/migration.c           | 158 ++++++++++++++++++++++++++++++++++++++++++
  hw/vfio/trace-events          |   2 +
  include/hw/vfio/vfio-common.h |   4 ++
  3 files changed, 164 insertions(+)

diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
index fd7faf423cdc..65ce735d667b 100644
--- a/hw/vfio/migration.c
+++ b/hw/vfio/migration.c
[snip]
@@ -64,6 +216,9 @@ static int vfio_migration_init(VFIODevice *vbasedev,
          ret = -EINVAL;
          goto err;
      }
+
+    migration->vm_state = qemu_add_vm_change_state_handler(vfio_vmstate_change,
+                                                           vbasedev);
      return 0;
err:

Fails to build, @migration is not defined.  We could use
vbasedev->migration or pull defining and setting @migration from patch
06.  Thanks,


Pulling and setting migration from patch 06 seems better option.
Should I resend patch 5 & 6 only?

Thanks,
Kirti

Reply via email to