Patchew URL: https://patchew.org/QEMU/20201027055317.351868-1-michael.r...@amd.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201027055317.351868-1-michael.r...@amd.com Subject: [PULL 00/12] qemu-ga patch queue for soft-freeze === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20201010204106.1368710-1-marcandre.lur...@redhat.com -> patchew/20201010204106.1368710-1-marcandre.lur...@redhat.com - [tag update] patchew/20201026195131.13848-1-js...@redhat.com -> patchew/20201026195131.13848-1-js...@redhat.com - [tag update] patchew/20201027050556.269064-1-ebl...@redhat.com -> patchew/20201027050556.269064-1-ebl...@redhat.com * [new tag] patchew/20201027055317.351868-1-michael.r...@amd.com -> patchew/20201027055317.351868-1-michael.r...@amd.com Switched to a new branch 'test' d9477b5 qga: add ssh-get-authorized-keys 244442a meson: minor simplification 4c591be qga: add *reset argument to ssh-add-authorized-keys 4857cb4 qga: add ssh-{add,remove}-authorized-keys 8ec1e2c glib-compat: add g_unix_get_passwd_entry_qemu() 20a139e qga: add implementation of guest-get-disks for Windows 4b631f0 qga: add implementation of guest-get-disks for Linux 7ae8fe2 qga: add command guest-get-disks 0b92ab2 qga: Flatten simple union GuestDeviceId 46c759d qga-win: Fix guest-get-devices error API violations be683aa qga: Use common time encoding for guest-get-devices 'driver-date' c9ae53d qga: Rename guest-get-devices return member 'address' to 'id' === OUTPUT BEGIN === 1/12 Checking commit c9ae53d3e18d (qga: Rename guest-get-devices return member 'address' to 'id') 2/12 Checking commit be683aab37bc (qga: Use common time encoding for guest-get-devices 'driver-date') 3/12 Checking commit 46c759dcdc69 (qga-win: Fix guest-get-devices error API violations) 4/12 Checking commit 0b92ab2b2592 (qga: Flatten simple union GuestDeviceId) 5/12 Checking commit 7ae8fe2e031c (qga: add command guest-get-disks) 6/12 Checking commit 4b631f069f98 (qga: add implementation of guest-get-disks for Linux) 7/12 Checking commit 20a139e50765 (qga: add implementation of guest-get-disks for Windows) 8/12 Checking commit 8ec1e2cbda3f (glib-compat: add g_unix_get_passwd_entry_qemu()) WARNING: Block comments use a leading /* on a separate line #42: FILE: include/glib-compat.h:81: +/* Note: The fallback implementation is not MT-safe, and it returns a copy of WARNING: Block comments use a trailing */ on a separate line #45: FILE: include/glib-compat.h:84: + * GLib API substitution. */ total: 0 errors, 2 warnings, 38 lines checked Patch 8/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/12 Checking commit 4857cb4903be (qga: add ssh-{add,remove}-authorized-keys) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 ERROR: Use g_assert or g_assert_not_reached #67: FILE: qga/commands-posix-ssh.c:33: + g_assert_cmpint(ret, ==, 0); ERROR: Use g_assert or g_assert_not_reached #328: FILE: qga/commands-posix-ssh.c:294: + g_assert_cmpint(ret, ==, 0); ERROR: Use g_assert or g_assert_not_reached #333: FILE: qga/commands-posix-ssh.c:299: + g_assert_no_error(err); ERROR: Use g_assert or g_assert_not_reached #345: FILE: qga/commands-posix-ssh.c:311: + g_assert_no_error(err); ERROR: Use g_assert or g_assert_not_reached #347: FILE: qga/commands-posix-ssh.c:313: + g_assert_cmpstr(contents, ==, expected); ERROR: Use g_assert or g_assert_not_reached #384: FILE: qga/commands-posix-ssh.c:350: + g_assert_null(err); ERROR: Use g_assert or g_assert_not_reached #390: FILE: qga/commands-posix-ssh.c:356: + g_assert_null(err); ERROR: Use g_assert or g_assert_not_reached #411: FILE: qga/commands-posix-ssh.c:377: + g_assert_null(err); ERROR: Use g_assert or g_assert_not_reached #416: FILE: qga/commands-posix-ssh.c:382: + g_assert_null(err); total: 9 errors, 1 warnings, 474 lines checked Patch 9/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/12 Checking commit 4c591be51737 (qga: add *reset argument to ssh-add-authorized-keys) ERROR: Use g_assert or g_assert_not_reached #96: FILE: qga/commands-posix-ssh.c:381: + g_assert_null(err); ERROR: Use g_assert or g_assert_not_reached #106: FILE: qga/commands-posix-ssh.c:391: + g_assert_null(err); ERROR: Use g_assert or g_assert_not_reached #115: FILE: qga/commands-posix-ssh.c:400: + g_assert_null(err); total: 3 errors, 0 warnings, 121 lines checked Patch 10/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/12 Checking commit 244442a80936 (meson: minor simplification) 12/12 Checking commit d9477b5e77e2 (qga: add ssh-get-authorized-keys) ERROR: space prohibited between function name and open parenthesis '(' #57: FILE: qga/commands-posix-ssh.c:309: + return g_steal_pointer (&ret); ERROR: Use g_assert or g_assert_not_reached #81: FILE: qga/commands-posix-ssh.c:484: + g_assert_null(err); ERROR: Use g_assert or g_assert_not_reached #88: FILE: qga/commands-posix-ssh.c:491: + g_assert_cmpint(len, ==, 2); total: 3 errors, 0 warnings, 138 lines checked Patch 12/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201027055317.351868-1-michael.r...@amd.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
