Hi Peter, On 10/19/20 9:26 PM, Peter Maydell wrote: > On Wed, 14 Oct 2020 at 20:36, Dr. David Alan Gilbert (git) > <dgilb...@redhat.com> wrote: >> >> From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> >> >> Use of 0x%d - make up our mind as 0x%x >> >> Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> >> --- >> hw/arm/trace-events | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/arm/trace-events b/hw/arm/trace-events >> index c8a4d80f6b..a335ee891d 100644 >> --- a/hw/arm/trace-events >> +++ b/hw/arm/trace-events >> @@ -41,7 +41,7 @@ smmuv3_get_cd(uint64_t addr) "CD addr: 0x%"PRIx64 >> smmuv3_decode_cd(uint32_t oas) "oas=%d" >> smmuv3_decode_cd_tt(int i, uint32_t tsz, uint64_t ttb, uint32_t granule_sz, >> bool had) "TT[%d]:tsz:%d ttb:0x%"PRIx64" granule_sz:%d had:%d" >> smmuv3_cmdq_cfgi_ste(int streamid) "streamid =%d" >> -smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%d - end=0x%d" >> +smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%x - end=0x%x" > > Ah, I missed that you'd sent this patch before. > > Eric, do we want to use hex here, or should we go for > decimal the way we do with (almost) all the other > tracing of stream IDs (eg mmuv3_cmdq_cfgi_ste in the line before)? > > The other odd-one-out is smmuv3_find_ste which prints a hex > SID; I think the other tracing of SIDs is always decimal. I think my preference would be to use hexa here and in the other places.
Thanks Eric > > thanks > -- PMM >