Am 27.10.2020 um 16:24 hat Greg Kurz geschrieben: > On Tue, 27 Oct 2020 13:54:04 +0000 > Stefan Hajnoczi <stefa...@redhat.com> wrote: > > > On Fri, Oct 23, 2020 at 05:01:10PM +0200, Greg Kurz wrote: > > > +/** > > > + * End all quiescent sections started by bdrv_drain_all_begin(). This is > > > + * only needed when deleting a BDS before bdrv_drain_all_end() is called. > > > + */ > > > +void bdrv_drain_all_end_quiesce(BlockDriverState *bs); > > > > This function is only called from block.c. Can it be moved to the > > private block_int.h header? > > > > Ha, I wasn't aware of block_int.h... It seems to be a very good idea. > > > The code is not clear on whether bdrv_drain_all_end_quiesce() is an API > > that others can use or an internal helper function that must only be > > called by bdrv_close(). I came to the conclusion that the latter is true > > after reviewing the patch. > > > > Yes it is. > > > Please update the bdrv_drain_all_end_quiesce() doc comment to clarify > > that this function is an internal helper for bdrv_close() - no one else > > needs to worry about it. > > I'll do that. > > Thanks for the suggestions Stefan.
I already sent a pull request, so if you're going to change something, please make it a follow-up patch rather than a new patch version. Kevin
signature.asc
Description: PGP signature
