On Wed, Oct 28, 2020 at 12:18:18PM +0800, Chen Qun wrote: > When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: > target/ppc/mmu_helper.c: In function ‘dump_mmu’: > target/ppc/mmu_helper.c:1351:12: warning: this statement may fall through > [-Wimplicit-fallthrough=] > 1351 | if (ppc64_v3_radix(env_archcpu(env))) { > | ^ > target/ppc/mmu_helper.c:1358:5: note: here > 1358 | default: > | ^~~~~~~ > > Add the corresponding "fall through" comment to fix it. > > Reported-by: Euler Robot <euler.ro...@huawei.com> > Signed-off-by: Chen Qun <kuhn.chen...@huawei.com>
Acked-by: David Gibson <da...@gibson.dropbear.id.au> > --- > Cc: David Gibson <da...@gibson.dropbear.id.au> > --- > target/ppc/mmu_helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c > index 8972714775..51749b62df 100644 > --- a/target/ppc/mmu_helper.c > +++ b/target/ppc/mmu_helper.c > @@ -1355,6 +1355,7 @@ void dump_mmu(CPUPPCState *env) > break; > } > #endif > + /* fall through */ > default: > qemu_log_mask(LOG_UNIMP, "%s: unimplemented\n", __func__); > } -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature