On Tue, Oct 27, 2020 at 02:55:39PM +0100, Philippe Mathieu-Daudé wrote: > As all commands use the ADMIN queue, it is pointless to pass > it as argument each time. Remove the argument. > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > block/nvme.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/block/nvme.c b/block/nvme.c > index 2d3648694b0..68f0c3f7959 100644 > --- a/block/nvme.c > +++ b/block/nvme.c > @@ -487,9 +487,10 @@ static void nvme_cmd_sync_cb(void *opaque, int ret) > aio_wait_kick(); > } > > -static int nvme_cmd_sync(BlockDriverState *bs, NVMeQueuePair *q, > - NvmeCmd *cmd) > +static int nvme_cmd_sync(BlockDriverState *bs, NvmeCmd *cmd)
Please rename the function to nvme_admin_cmd_sync() so it's behavior is clear.
signature.asc
Description: PGP signature
