On 08/22/2011 05:16 PM, Gerhard Wiesinger wrote:
Hello Avi,
Thnx, fixed: OK, maybe some credits :-)
Acked-by: Gerhard Wiesinger <li...@wiesinger.com>
This pattern is still present at (maybe some further problems!!!) and
I guess it has to be fixed, too:
grep -ir 'ops, s, "' .
./hw/rtl8139.c: memory_region_init_io(&s->bar_io, &rtl8139_io_ops,
s, "rtl8139", 0x100);
./hw/rtl8139.c: memory_region_init_io(&s->bar_mem,
&rtl8139_mmio_ops, s, "rtl8139", 0x100);
Usually, when you have
memory_region_init_io(&s->something, ..., s, ...)
it means everything is fine. Lance/pcnet is special in this regard.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
