On Fri, Oct 30, 2020 at 02:03:07PM +0400, Marc-André Lureau wrote: > On Fri, Oct 30, 2020 at 2:17 AM Eduardo Habkost <ehabk...@redhat.com> wrote: > > > The array property registration code is hard to follow. Move the > > two steps into separate functions that have clear > > responsibilities. > > > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > > --- > > Cc: Paolo Bonzini <pbonz...@redhat.com> > > Cc: "Daniel P. Berrangé" <berra...@redhat.com> > > Cc: Eduardo Habkost <ehabk...@redhat.com> > > Cc: qemu-devel@nongnu.org > > --- > > hw/core/qdev-properties.c | 60 ++++++++++++++++++++++++++------------- > > 1 file changed, 41 insertions(+), 19 deletions(-) > > > > diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c > > index 27c09255d7..1f06dfb5d5 100644 > > --- a/hw/core/qdev-properties.c > > +++ b/hw/core/qdev-properties.c > > @@ -588,6 +588,32 @@ typedef struct { > > ObjectPropertyRelease *release; > > } ArrayElementProperty; > > > > +/** > > + * Create ArrayElementProperty based on array length property > > + * @array_len_prop (which was previously defined using > > DEFINE_PROP_ARRAY()). > > + */ > > > > (some day we will have to clarify our API doc style, but not now ;)
In this specific case, this one was not supposed to be a real doc comment. My first version of this commit had a full doc comment, then I decided it was overkill for an internal static function and I made it a plain paragraph. The "/**" and "@array_len_prop" are leftovers from the old doc comment and I will remove them if respinning the series. > > +static ArrayElementProperty *array_element_new(Object *obj, -- Eduardo