On Mon, Nov 02, 2020 at 10:59:43AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé <berra...@redhat.com> writes: > > > On Mon, Nov 02, 2020 at 09:44:49AM +0100, Markus Armbruster wrote: > >> Daniel P. Berrangé <berra...@redhat.com> writes: > >> > >> > On Fri, Oct 30, 2020 at 11:11:19AM +0100, Markus Armbruster wrote: > >> >> Marc-André Lureau <marcandre.lur...@gmail.com> writes: > >> >> > >> >> > Hi Markus, > >> >> > > >> >> > On Thu, Oct 29, 2020 at 5:43 PM Markus Armbruster <arm...@redhat.com> > >> >> > wrote: > [...] > >> >> >> Regardless, I *will* make time for ripping the feature out if we > >> >> >> decide to do that. Quick & easy way to avoid reviewing this series > >> >> >> *hint* *hint*. > >> >> >> > >> >> > > >> >> > well, fwiw, I would also take that approach too, to the risk of > >> >> > upsetting > >> >> > the users. > >> >> > >> >> Reverting the feature requires rough consensus and a patch. > >> >> > >> >> I can provide a patch, but let's give everybody a chance to object > >> >> first. > >> > >> Daniel, do you object, yes or no? > > > > Yes, I object to removing the feature as it is clearly useful. > > Thanks. I sent v2 of my fixes. Can you take care of getting them > merged, hopefully in time for 5.2?
Sure, I'll aim to review & send PR today / tomorrow. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
