On 08/24/2011 03:46 PM, Jan Kiszka wrote:
> +++ b/hw/vga.c
> @@ -179,6 +179,8 @@ static void vga_update_memory_access(VGACommonState *s)
> base = 0xb8000;
> size = 0x8000;
> break;
> + default:
> + abort();
> }
> region = g_malloc(sizeof(*region));
> memory_region_init_alias(region, "vga.chain4",&s->vram, offset,
size);
...or just make the last case default?
No reason to make the code unobvious in this path, IMO. Eventually gcc
will be able to drop the 4/5 bytes this patch adds to the object code.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
