Patchew URL: https://patchew.org/QEMU/20201103011134.887744-1-michael.r...@amd.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201103011134.887744-1-michael.r...@amd.com Subject: [PULL v2 00/12] qemu-ga patch queue for soft-freeze === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20201102202710.2224691-1-f4...@amsat.org -> patchew/20201102202710.2224691-1-f4...@amsat.org - [tag update] patchew/20201102203609.2228309-1-phi...@redhat.com -> patchew/20201102203609.2228309-1-phi...@redhat.com * [new tag] patchew/20201103011134.887744-1-michael.r...@amd.com -> patchew/20201103011134.887744-1-michael.r...@amd.com Switched to a new branch 'test' 134f664 qga: add ssh-get-authorized-keys 9f5e642 meson: minor simplification 445e4c4 qga: add *reset argument to ssh-add-authorized-keys 7ab2def qga: add ssh-{add,remove}-authorized-keys b137836 glib-compat: add g_unix_get_passwd_entry_qemu() bf1041a qga: add implementation of guest-get-disks for Windows 78bc690 qga: add implementation of guest-get-disks for Linux de60426 qga: add command guest-get-disks e8dc031 qga: Flatten simple union GuestDeviceId a78863f qga-win: Fix guest-get-devices error API violations 3d3253f qga: Use common time encoding for guest-get-devices 'driver-date' 1965fac qga: Rename guest-get-devices return member 'address' to 'id' === OUTPUT BEGIN === 1/12 Checking commit 1965fac569d1 (qga: Rename guest-get-devices return member 'address' to 'id') 2/12 Checking commit 3d3253f3695c (qga: Use common time encoding for guest-get-devices 'driver-date') 3/12 Checking commit a78863f8a833 (qga-win: Fix guest-get-devices error API violations) 4/12 Checking commit e8dc03167d53 (qga: Flatten simple union GuestDeviceId) 5/12 Checking commit de60426a744f (qga: add command guest-get-disks) 6/12 Checking commit 78bc69001515 (qga: add implementation of guest-get-disks for Linux) 7/12 Checking commit bf1041a868af (qga: add implementation of guest-get-disks for Windows) 8/12 Checking commit b1378362971f (glib-compat: add g_unix_get_passwd_entry_qemu()) WARNING: Block comments use a leading /* on a separate line #42: FILE: include/glib-compat.h:81: +/* Note: The fallback implementation is not MT-safe, and it returns a copy of WARNING: Block comments use a trailing */ on a separate line #45: FILE: include/glib-compat.h:84: + * GLib API substitution. */ total: 0 errors, 2 warnings, 38 lines checked Patch 8/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/12 Checking commit 7ab2def768e8 (qga: add ssh-{add,remove}-authorized-keys) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 ERROR: Use g_assert or g_assert_not_reached #69: FILE: qga/commands-posix-ssh.c:33: + g_assert_cmpint(ret, ==, 0); ERROR: Use g_assert or g_assert_not_reached #330: FILE: qga/commands-posix-ssh.c:294: + g_assert_cmpint(ret, ==, 0); ERROR: Use g_assert or g_assert_not_reached #335: FILE: qga/commands-posix-ssh.c:299: + g_assert_no_error(err); ERROR: Use g_assert or g_assert_not_reached #347: FILE: qga/commands-posix-ssh.c:311: + g_assert_no_error(err); ERROR: Use g_assert or g_assert_not_reached #349: FILE: qga/commands-posix-ssh.c:313: + g_assert_cmpstr(contents, ==, expected); ERROR: Use g_assert or g_assert_not_reached #386: FILE: qga/commands-posix-ssh.c:350: + g_assert_null(err); ERROR: Use g_assert or g_assert_not_reached #392: FILE: qga/commands-posix-ssh.c:356: + g_assert_null(err); ERROR: Use g_assert or g_assert_not_reached #413: FILE: qga/commands-posix-ssh.c:377: + g_assert_null(err); ERROR: Use g_assert or g_assert_not_reached #418: FILE: qga/commands-posix-ssh.c:382: + g_assert_null(err); total: 9 errors, 1 warnings, 479 lines checked Patch 9/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/12 Checking commit 445e4c4ff87d (qga: add *reset argument to ssh-add-authorized-keys) ERROR: Use g_assert or g_assert_not_reached #96: FILE: qga/commands-posix-ssh.c:381: + g_assert_null(err); ERROR: Use g_assert or g_assert_not_reached #106: FILE: qga/commands-posix-ssh.c:391: + g_assert_null(err); ERROR: Use g_assert or g_assert_not_reached #115: FILE: qga/commands-posix-ssh.c:400: + g_assert_null(err); total: 3 errors, 0 warnings, 121 lines checked Patch 10/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/12 Checking commit 9f5e6424dba4 (meson: minor simplification) 12/12 Checking commit 134f66443ae0 (qga: add ssh-get-authorized-keys) ERROR: space prohibited between function name and open parenthesis '(' #60: FILE: qga/commands-posix-ssh.c:309: + return g_steal_pointer (&ret); ERROR: Use g_assert or g_assert_not_reached #84: FILE: qga/commands-posix-ssh.c:484: + g_assert_null(err); ERROR: Use g_assert or g_assert_not_reached #91: FILE: qga/commands-posix-ssh.c:491: + g_assert_cmpint(len, ==, 2); total: 3 errors, 0 warnings, 138 lines checked Patch 12/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201103011134.887744-1-michael.r...@amd.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com