QemuOpts lets you write boolean options in "short form" where "abc" means "abc=on" and "noabc" means "abc=off". This is confusing, since it is not done for the first key=value pair but only if there is an implied key; it can also be grossly misused, for example "-device e1000,noid" will create a device with id equal to "off".
Unfortunately, this idiom has found wide use with -chardev (think "server,nowait") and to a lesser extent -spice. Patch 4 in this series deprecates it for all other option groups. The first three patches avoid emitting the warning in tests (which in one case were buggy, see patch 3) or for the "help" option. Paolo Bonzini (4): ivshmem-test: do not use short-form boolean option qemu-option: move help handling to get_opt_name_value qtest: escape device name in device-introspect-test qemu-option: warn for short-form boolean options chardev/char.c | 1 + docs/system/deprecated.rst | 7 ++++ include/qemu/option.h | 1 + tests/qtest/device-introspect-test.c | 9 +++-- tests/qtest/ivshmem-test.c | 2 +- tests/test-qemu-opts.c | 1 + ui/spice-core.c | 1 + util/qemu-option.c | 51 ++++++++++++++++------------ 8 files changed, 48 insertions(+), 25 deletions(-) -- 2.26.2
