On 03/11/2020 21.41, Philippe Mathieu-Daudé wrote: > On 11/3/20 7:43 PM, Thomas Huth wrote: >> On 03/11/2020 17.46, Philippe Mathieu-Daudé wrote: [...] >>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml >>> index 3b15ae5c302..6ee098ec53c 100644 >>> --- a/.gitlab-ci.yml >>> +++ b/.gitlab-ci.yml >>> @@ -262,6 +262,17 @@ build-user-plugins: >>> MAKE_CHECK_ARGS: check-tcg >>> timeout: 1h 30m >>> >>> +build-system-ubuntu-without-default-devices: >>> + <<: *native_build_job_definition >>> + variables: >>> + IMAGE: ubuntu2004 >>> + CONFIGURE_ARGS: --without-default-devices --disable-user --disable-xen >>> --disable-tools --disable-docs >>> + MAKE_CHECK_ARGS: check-build >> >> AFAIK "check-build" is pretty much a no-op since the convertion to meson ... >> could you maybe replace with a set of qtest targets that work, to make sure >> that we do not regress here? E.g.: >> >> MAKE_CHECK_ARGS: check-qtest-avr check-qtestcris check-qtest-m68k >> check-qtest-microblaze check-qtest-mipsel check-qtest-moxie ... > > qtests don't work with --without-default-devices, as we don't check > for (un-)available devices.
Sure, "make check-qtest" does not work, I know. But some targets work fine, e.g. "make check-qtest-avr", and that's what I've suggested. By testing those targets, we can make sure that the qtests don't regress any further with --without-default-devices. > I'll try check-unit. I think that does not have much benefit since it should be independent of the devices and is tested in the other pipelines already? Thomas