Patchew URL: https://patchew.org/QEMU/20201104160021.2342108-1-ehabk...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201104160021.2342108-1-ehabk...@redhat.com Subject: [PATCH v2 00/44] Make qdev static property API usable by any QOM type === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20201104160021.2342108-1-ehabk...@redhat.com -> patchew/20201104160021.2342108-1-ehabk...@redhat.com - [tag update] patchew/cover.1604464950.git.alistair.fran...@wdc.com -> patchew/cover.1604464950.git.alistair.fran...@wdc.com Switched to a new branch 'test' 74d2a4f machine: Register most properties as field properties e57a72b tests: Use field properties at check-qom-proplist test case 46f06f6 qom: Include static property API reference in documentation e2754e0 qdev: Move base property types to qom/property-types.c c83750c qdev: Move core field property code to QOM c1f0ca8 qdev: PROP_* macros ba5c6dc qdev: Rename qdev_prop_* to prop_info_* 151ee6d qdev: Move qdev_prop_tpm declaration to tpm_prop.h d69260f qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr() a403dfd qdev: Rename qdev_propinfo_* to field_prop_* abf9c0e qdev: Make qdev_propinfo_get_uint16() static 949e6fd qdev: Make qdev_prop_allow_set() a ObjectProperty.allow_set callback 5b51a20 qom: Add allow_set callback to ObjectProperty a785525 qdev: Reuse object_property_add_field() when adding array elements 9c2a384 qdev: Get rid of ArrayElementProperty struct ae7a992 qdev: Remove ArrayElementProperty.propname field f065d16 qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen() 529f3bf qdev: Don't set qdev_prop_name for array elements a0b808f qdev: Rename Property.name to Property.qdev_prop_name 531c8f7 qdev: Separate generic and device-specific property registration d7a02b8 qdev: Make qdev_class_add_property() more flexible 05ee196 qdev: Make PropertyInfo.create return ObjectProperty* ff520f7 qdev: Move dev->realized check to qdev_property_set() 2822481 qdev: Wrap getters and setters in separate helpers e25f29d qdev: Add name argument to PropertyInfo.create method a709b9f qdev: Add name parameter to qdev_class_add_property() 0dac961 qdev: Avoid using prop->name unnecessarily 460626c qdev: Get just property name at error_set_from_qdev_prop_error() 3b17a2f sparc: Use DEFINE_PROP for nwindows property 5d719ec qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macros 461571e qdev: Move softmmu properties to qdev-properties-system.h 39ddc78 qdev: Move UUID property to qdev-properties-system.c 0f14166 qdev: Make error_set_from_qdev_prop_error() get Object* argument 9785bda qdev: Make check_prop_still_unset() get Object* argument f0f09a3 qdev: Make qdev_find_global_prop() get Object* argument 755cc12 qdev: Make qdev_get_prop_ptr() get Object* arg 743a7b9 qdev: Make bit_prop_set() get Object* argument c2dedd0 qdev: Make PropertyInfo.print method get Object* argument 40c9d21 qdev: Don't use dev->id on set_size32() error message 8ca5b2b sparc: Check dev->realized at sparc_set_nwindows() bc82801 qdev: Check dev->realized at set_size() f2497db qdev: Move property code to qdev-properties.[ch] 969306e cpu: Move cpu_common_props to hw/core/cpu.c 3d0ba5f cs4231: Get rid of empty property array === OUTPUT BEGIN === 1/44 Checking commit 3d0ba5f057e5 (cs4231: Get rid of empty property array) 2/44 Checking commit 969306e01eb3 (cpu: Move cpu_common_props to hw/core/cpu.c) WARNING: Block comments use a leading /* on a separate line #51: FILE: hw/core/cpu.c:398: + /* Create a memory property for softmmu CPU object, total: 0 errors, 1 warnings, 49 lines checked Patch 2/44 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/44 Checking commit f2497db84ed4 (qdev: Move property code to qdev-properties.[ch]) 4/44 Checking commit bc8280160af2 (qdev: Check dev->realized at set_size()) 5/44 Checking commit 8ca5b2bcbef0 (sparc: Check dev->realized at sparc_set_nwindows()) 6/44 Checking commit 40c9d2144d73 (qdev: Don't use dev->id on set_size32() error message) 7/44 Checking commit c2dedd0f2664 (qdev: Make PropertyInfo.print method get Object* argument) 8/44 Checking commit 743a7b94d217 (qdev: Make bit_prop_set() get Object* argument) 9/44 Checking commit 755cc1262e1b (qdev: Make qdev_get_prop_ptr() get Object* arg) 10/44 Checking commit f0f09a33e829 (qdev: Make qdev_find_global_prop() get Object* argument) 11/44 Checking commit 9785bdade8e1 (qdev: Make check_prop_still_unset() get Object* argument) 12/44 Checking commit 0f14166bb10b (qdev: Make error_set_from_qdev_prop_error() get Object* argument) 13/44 Checking commit 39ddc785b42a (qdev: Move UUID property to qdev-properties-system.c) 14/44 Checking commit 461571e7c248 (qdev: Move softmmu properties to qdev-properties-system.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #879: new file mode 100644 total: 0 errors, 1 warnings, 700 lines checked Patch 14/44 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/44 Checking commit 5d719ec2d9af (qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macros) 16/44 Checking commit 3b17a2f75037 (sparc: Use DEFINE_PROP for nwindows property) 17/44 Checking commit 460626cfbfdf (qdev: Get just property name at error_set_from_qdev_prop_error()) 18/44 Checking commit 0dac96100bac (qdev: Avoid using prop->name unnecessarily) 19/44 Checking commit a709b9f94797 (qdev: Add name parameter to qdev_class_add_property()) 20/44 Checking commit e25f29d417a4 (qdev: Add name argument to PropertyInfo.create method) 21/44 Checking commit 282248183d5e (qdev: Wrap getters and setters in separate helpers) 22/44 Checking commit ff520f7eebac (qdev: Move dev->realized check to qdev_property_set()) 23/44 Checking commit 05ee196058a0 (qdev: Make PropertyInfo.create return ObjectProperty*) WARNING: line over 80 characters #33: FILE: hw/core/qdev-properties.c:829: + qdev_prop_allow_set_link_before_realize, total: 0 errors, 1 warnings, 28 lines checked Patch 23/44 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 24/44 Checking commit d7a02b80be4a (qdev: Make qdev_class_add_property() more flexible) 25/44 Checking commit 531c8f760558 (qdev: Separate generic and device-specific property registration) 26/44 Checking commit a0b808face3a (qdev: Rename Property.name to Property.qdev_prop_name) WARNING: line over 80 characters #129: FILE: softmmu/qdev-monitor.c:707: + value = object_property_print(OBJECT(dev), props->qdev_prop_name, true, total: 0 errors, 1 warnings, 105 lines checked Patch 26/44 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 27/44 Checking commit 529f3bfca271 (qdev: Don't set qdev_prop_name for array elements) 28/44 Checking commit f065d1696dbe (qdev: Avoid unnecessary DeviceState* variable at set_prop_arraylen()) 29/44 Checking commit ae7a99263c15 (qdev: Remove ArrayElementProperty.propname field) 30/44 Checking commit 9c2a3841ee20 (qdev: Get rid of ArrayElementProperty struct) 31/44 Checking commit a7855258978f (qdev: Reuse object_property_add_field() when adding array elements) 32/44 Checking commit 5b51a20c251d (qom: Add allow_set callback to ObjectProperty) 33/44 Checking commit 949e6fd4ca12 (qdev: Make qdev_prop_allow_set() a ObjectProperty.allow_set callback) 34/44 Checking commit abf9c0ec584b (qdev: Make qdev_propinfo_get_uint16() static) 35/44 Checking commit a403dfd606b4 (qdev: Rename qdev_propinfo_* to field_prop_*) 36/44 Checking commit d69260f76ab9 (qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr()) 37/44 Checking commit 151ee6da64f2 (qdev: Move qdev_prop_tpm declaration to tpm_prop.h) 38/44 Checking commit ba5c6dc490b9 (qdev: Rename qdev_prop_* to prop_info_*) 39/44 Checking commit c1f0ca806ddf (qdev: PROP_* macros) ERROR: storage class should be at the beginning of the declaration #28: FILE: include/hw/qdev-properties.h:183: + ({ static Property _p = def; &p; }) total: 1 errors, 0 warnings, 60 lines checked Patch 39/44 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/44 Checking commit c83750c46889 (qdev: Move core field property code to QOM) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #255: rename from hw/core/qdev-prop-internal.h total: 0 errors, 1 warnings, 428 lines checked Patch 40/44 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 41/44 Checking commit e2754e0204f6 (qdev: Move base property types to qom/property-types.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #759: new file mode 100644 ERROR: storage class should be at the beginning of the declaration #901: FILE: include/qom/property-types.h:138: + ({ static Property _p = def; &p; }) WARNING: Block comments use a leading /* on a separate line #1408: FILE: qom/property-types.c:442: + /* Setter for the property which defines the length of a WARNING: Block comments use a leading /* on a separate line #1433: FILE: qom/property-types.c:467: + /* DEFINE_PROP_ARRAY guarantees that name should start with this prefix; WARNING: Block comments use a leading /* on a separate line #1440: FILE: qom/property-types.c:474: + /* Note that it is the responsibility of the individual device's deinit WARNING: Block comments use a leading /* on a separate line #1448: FILE: qom/property-types.c:482: + /* This ugly piece of pointer arithmetic sets up the offset so total: 1 errors, 5 warnings, 1471 lines checked Patch 41/44 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 42/44 Checking commit 46f06f686087 (qom: Include static property API reference in documentation) WARNING: line over 80 characters #81: FILE: include/qom/field-property.h:40: + * @defval: default value for the property. This is used only if @set_default total: 0 errors, 1 warnings, 271 lines checked Patch 42/44 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 43/44 Checking commit e57a72b253fa (tests: Use field properties at check-qom-proplist test case) ERROR: storage class should be at the beginning of the declaration #22: FILE: include/qom/property-types.h:245: + ({ static Property _p = def; &_p; }) total: 1 errors, 0 warnings, 107 lines checked Patch 43/44 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 44/44 Checking commit 74d2a4fb19a6 (machine: Register most properties as field properties) WARNING: line over 80 characters #294: FILE: hw/core/machine.c:643: + PROP_BOOL(MachineState, dump_guest_core, true), WARNING: line over 80 characters #314: FILE: hw/core/machine.c:659: + PROP_BOOL(MachineState, enable_graphics, true), WARNING: line over 80 characters #330: FILE: hw/core/machine.c:670: + PROP_BOOL(MachineState, suppress_vmdesc, false), total: 0 errors, 3 warnings, 346 lines checked Patch 44/44 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201104160021.2342108-1-ehabk...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com