On 11/6/20 7:27 AM, Peter Maydell wrote: > Unlike the kernel macros, our __get_user() and __put_user() do not > return a failure code. Kernel code typically has a style of > err |= __get_user(...); err |= __get_user(...); > and then checking err at the end. In sparc64_get_context() our > version of the code dropped the accumulating into err but left the > "if (err) goto do_sigsegv" checks, which will never be taken. Delete > unnecessary if()s. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > linux-user/sparc/signal.c | 4 ---- > 1 file changed, 4 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~