On 08/11/2020 21.45, Philippe Mathieu-Daudé wrote: > Add these missing options to the 'build-disabled' job: > --disable-auth-pam (commit 8953caf3cd38) > --disable-gcrypt (commit 91bfcdb01d48) > --disable-keyring (commit 54e7aac05624) > --disable-libudev (commit 5c53015a480b) > --disable-opengl (commit da076ffed6b9) > --disable-sparse (commit 03b4fe7de226) > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > .gitlab-ci.yml | 7 +++++++ > 1 file changed, 7 insertions(+) [...] > @@ -258,6 +264,7 @@ build-disabled: > --disable-vhost-net > --disable-vhost-scsi > --disable-vhost-user > + --disable-vhost-user-blk-server > --disable-vhost-vdpa > --disable-vhost-vsock > --disable-virglrenderer
vhost-user-blk-server should get automatically disabled by --disable-vhost-user ... so maybe drop this hunk, so that we're able to detect problems with this logic in the future, too? (as we've just seen with the current build failures in the CI) ... if you insist on keeping this hunk, I think you should at least mention it in the patch description (since you've mentioned all the other options there) Thomas
